Update propeller sharding docs - types needs to be capitalized #5860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the lowercase version of e.g. `project` the following error is raised by flytepropeller-manager ``` level=error msg="\n\n1 error(s) decoding:\n\n* cannot parse 'shard.type' as int: strconv.ParseInt: parsing \"project\": invalid syntax" ``` Signed-off-by: Christoph Paulik <[email protected]>
cpaulik
force-pushed
the
flytepropeller-sharding-doc-update
branch
from
56c3f1c
to
82afb0d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5860 +/- ##
==========================================
- Coverage 36.72% 34.85% -1.87%
==========================================
Files 1304 1138 -166
Lines 130072 121275 -8797
==========================================
- Hits 47764 42273 -5491
+ Misses 78138 75325 -2813
+ Partials 4170 3677 -493
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Using the lowercase version of e.g.
projectthe following error is raised by flytepropeller-managerHow was this patch tested?
Tested uppercase
Projectin our Flyte deployment. I did not test the uppercaseDomainoption. That one is just an assumption based on the need to uppercaseHashandProject.